Skip to content

usage(): do not emit blank line when a single argument exceeds set_usage_max_line_width() #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
p-ranav merged 1 commit into from
Jan 20, 2025
Merged

usage(): do not emit blank line when a single argument exceeds set_usage_max_line_width() #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/argparse/argparse.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2128,7 +2128,8 @@ class ArgumentParser {
}
}
cur_mutex = arg_mutex;
if (curline.size() + 1 + arg_inline_usage.size() >
if (curline.size() != indent_size &&
curline.size() + 1 + arg_inline_usage.size() >
this->m_usage_max_line_width) {
stream << curline << std::endl;
curline = std::string(indent_size, ' ');
Expand Down
10 changes: 10 additions & 0 deletions test/test_help.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,3 +244,13 @@ TEST_CASE("multiline usage, break on mutex") {
" [--will-go-on-new-line]\n"
" [--on-a-dedicated-line]");
}

TEST_CASE("multiline usage, single arg that is larger than the max width") {
argparse::ArgumentParser program("program");
program.set_usage_max_line_width(80);
program.add_argument("--lots-of-choices").metavar("<veeeeeeeeeeeeeeeeeeeeeeeeeeery_long|veeeeeeeeeeeeeeeeeeeery_long2>");
// std::cout << "DEBUG:" << program.usage() << std::endl;
REQUIRE(program.usage() ==
"Usage: program [--help] [--version]\n"
" [--lots-of-choices <veeeeeeeeeeeeeeeeeeeeeeeeeeery_long|veeeeeeeeeeeeeeeeeeeery_long2>]");
}
Loading