Improve performance of file I/O using mmap #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
p-x9
commented
Jul 25, 2025
p-x9
commented
- Improve performance of file I/O using mmap MachOKit#195
#Conflicts: # Package.resolved # Package.swift
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves file I/O performance by replacing Foundation's FileHandle with memory-mapped file operations using a new FileIO dependency.
- Replaces FileHandle with MemoryMappedFile for better performance
- Updates API calls from
sizetolengthparameter and addstry!for error handling - Adds comprehensive extension methods for the new FileIO protocol
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Package.swift | Adds swift-fileio dependency |
| Sources/MachOObjCSection/Extension/MachOFile+.swift | Replaces FileHandle with MemoryMappedFile |
| Sources/MachOObjCSection/Extension/DyldCache+.swift | Replaces FileHandle with MemoryMappedFile |
| Sources/MachOObjCSection/Extension/_FileIOProtocol+.swift | New extension file providing FileIO protocol methods |
| Multiple Protocol files | Updates readData calls to use new API with try! and length parameter |
| Xcode scheme files | New Xcode scheme configurations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.