Conversation
… add mypy, document use of literals
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #32
While writing this, realized there was a very easy path to get basic mypy compatibility, even though it doesn't get us to where we want to be.
We should at least be able to write annotations without needing to ignore major linter rules and failing mypy altogether.
Following #55 mypy will actually use the type stub,
and previously we have implemented support for
Literalinstead ofShape, though this wasn't documented?The only thing remaining was that mypy didn't detect that
NDArrayandShapeshould accept generic params, added them to the type stub and to the shape class. theFinalclass creation and theImmutablemetaclasses interfered with being able to set the generic dunder attrs, and they are sorta silly anyway, don't really accomplish anything, and will be deprecated soon, so they were removed.Added the most basic mypy test and a tiny bit of documentation on using literals