Feat: Improve sar_portalcolor_* on SinglePlayer
#297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By patching the branch instruction, force the multiplayer portal/ghostportal material when using sar_portalcolor
drawportalghost is probably different on infra, but it doesn't matter if we find it anyway since there are no portals
and "cleaner" by using Memory::Patch instead of mid hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By patching the branch instruction, force the multiplayer portal/ghostportal material when using sar_portalcolor_enable on SinglePlayer.
Overriding
gamerules->IsMultiplayerwont work in neither of the functions because that would cause the code to derefPortalMPGameRules()->IsCoOp(), which its null on single player.I'm not familiar with the code base, so if there is something that could improve, i'll appreciate the advice
TODO:
Implement the same for Linux, and if relevant, older builds of portal, should be possible and in fact, i do know where each function is located at
client.so, but i don't know any good tools like cheat engine for Linux to reverse engineer the game