feat: floor reportals patch #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds back in reportal boosts from floor reportals.
a) we don't trust FCVAR_CHEAT to handle all possible cheating like a silver bullet. you can turn on the cvar in singleplayer without cheats on, for example. to be extra safe with cheat features, we don't rely on change callbacks and instead check it every tick b) we don't need to do this whole mess with iNewConVarValue and pszNewConVarVal, just use a boolean lmfao. at the moment, we don't use change callbacks at all, but this could change in the future. c) Memory::Patch is made specifically for this kind of thing, and flushing the instruction cache is unnecessary. We don't need to nop the jump instruction entirely, just switch the instruction to JO (jump if overflow) which is never true by nature. This makes the logic more concise and less intrusive. The first `patch->Execute` initializes the patch with the data it is replacing. d) as a general housekeeping convention, keep the newline at EOF. visual studio likes to kill it automatically, which is part of why i just don't use it. e) the boards API is not necessarily board.portal2.sr. for example, mel is mel.board.portal2.sr, and others can be added in future. see src/Features/AutoSubmit.cpp:431
KiIoOnline
commented
Apr 15, 2025
Contributor
Author
KiIoOnline
left a comment
KiIoOnline
left a comment
There was a problem hiding this comment.
Tested out the changes, works the same as the previous implementation so looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back in reportal boosts from floor reportals.