feat: Check for Pause in challenge mode runs of Wakeup #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
converted to draft because this feature does not work with |
…ct feature work with sar_disable_challenge_stats_hud values that are not -1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check to the AutoSubmit FinishRun function that does not submit if the user pauses the game in Wakeup, a map which in fullgame uses pause abuse to save time. New runners semi-frequently do challenge mode runs of wakeup without checking the differences in rules between fullgame and cm, and submit a time using pause abuse. The check was requested in #cm-boards channel of the P2SR discord here.
I have tested this feature by completing a run that is a new pb with pause abuse and the check catches it, a run on a map that is not wakeup that pauses does not get caught in the check, a run on wakeup that does not pause at first was considered a run that had a pause in it (I assume it was because at the end you go to the pause menu?) however adding a check to make sure that the pause happened while the timer was running seems to have fixed this issue.