Update bazel build to c++17 #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: verios-google <[email protected]>
Contributor
Author
|
@smolkaj, @chrispsommers, @jafingerhut can I get a review please |
Contributor
|
@verios-google The changes look pretty small and straightforward, but what I know about Bazel wouldn't fill a teaspoon, so I feel a bit wary about merging this based on my knowledge. If Steffen doesn't get a chance to review it soon, feel free to ping me again in a couple of days and I can approve it. |
Contributor
Author
|
Thanks, will do if that's the case |
smolkaj
approved these changes
Apr 4, 2025
Member
smolkaj
left a comment
smolkaj
left a comment
There was a problem hiding this comment.
LGTM. p4c is already on C++17 (see eg https://github.com/p4lang/p4c/blob/main/.bazelrc#L6-L8)
Member
|
@chrispsommers could you also PTAL and hit merge if there are no concerns? |
chrispsommers
approved these changes
Apr 4, 2025
Collaborator
chrispsommers
left a comment
chrispsommers
left a comment
There was a problem hiding this comment.
Relying on Steffen, but looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update bazel build to c++17
c++17 has been out for awhile so this is a stable update.
c++17 is a prerequisite for migrating from proto3 to proto editions so would be nice to clear that prerequisite early