-
Notifications
You must be signed in to change notification settings - Fork 99
Add Any protobuf message to CapabilitiesResponse for experimental features
#554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…mental features before proposing them for standardization Signed-off-by: verios-google <[email protected]>
|
Looks interesting, let's discuss at the next P4-APi WG meeting! |
Signed-off-by: verios-google <[email protected]>
chrispsommers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@chrispsommers can you merge this, I'm not authorized to do this. Unless you're waiting on someone else's approval |
smolkaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits
jonathan-dilorenzo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Victor. Basically just what Steffen said.
Signed-off-by: verios-google <[email protected]>
jonathan-dilorenzo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
smolkaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final nit, approving early.
Signed-off-by: verios-google <[email protected]>
|
Chris already approved, so I'll go ahead and submit. |
The
Anyprotobuf message would allow parties to experiment with new capability responses before proposing them for standardization. This provides a convenient way to try experimental features while remaining in sync with the repo.A quick guide for how to use the
Anymessage can be found hereAn example of how this may be used:
This example is for fun but one could imagine a plethora of capabilities a switch/NIC/hardware may advertise. The P4 runtime specification does advertise some capabilities (e.g. table sizes) and the p4 constraints repo allows for more complex restrictions on entries, but there is still a large number of capabilities that cannot be captured by current solutions (e.g. two tables sharing resources).
NOTE: In the future, it would super nice to migrate
p4runtime.protofromproto3to protoeditions. When that happens, this (and possibly other existing)Anyprotobuf message(s) should be replaced with protoextensions. I added a comment in the spec for awareness.