Add device_id field to capabilites request

[verios-google]

Pretty self-explanatory. A controller can speak to more than one switch, best to know which switch the request is for.

[verios-google]

@chrispsommers and @jonathan-dilorenzo, any other open concerns for the PR, otherwise can I get approval and merger

[jonathan-dilorenzo]

LGTM!

[jonathan-dilorenzo]

So, if we think there's anything to discuss here, @antoninbas and @chrispsommers, then we could chat in meeting on Friday. O.w. I'd be comfortable with this getting merged as it looks now (or with whatever additional comments you have)?

[chrispsommers]

LGTM

[chrispsommers]

So, if we think there's anything to discuss here, @antoninbas and @chrispsommers, then we could chat in meeting on Friday. O.w. I'd be comfortable with this getting merged as it looks now (or with whatever additional comments you have)?

I'm OK with as-is.

[verios-google]

@antoninbas any other concerns or can we merge this

[antoninbas]

LGTM, thanks for making the suggested change

I'd recommend making it explicit that 0 is not a valid device_id in a follow-up change. When I looked at the spec the other day, I couldn't find any mention of this, even though we do have a general statement that the zero value for scalar fields is usually not valid.

[verios-google]

Sounds good, I'll take a stab at it when I get the time. @chrispsommers can you merge this PR

[chrispsommers]

Sounds good, I'll take a stab at it when I get the time. @chrispsommers can you merge this PR

If you're going to add a sentence about device_id 0 isn't valid, how about do that before we merge? It sounds trivial and will avoid yet another PR. We can merge in the meeting today, one way or the other.