Add TIN check, Strict mode and Country check (idea for complementing this library)#14
Add TIN check, Strict mode and Country check (idea for complementing this library)#14ortegafernando wants to merge 11 commits intopH-7:mainfrom
Conversation
|
Thank you so much for your contribution @ortegafernando!! 🎉 I really appreciate this! 😊 Could you add some unit tests (in a new test file). You can have a look at the existing unit tests already written - https://github.com/pH-7/eu-vat-validator/tree/main/tests/Vat Any other testing or changes, please let me know. Then, I will be happy to merge your contribution to the project 🚀 Enjoy the rest of your weekend. |
|
Hi, I am a newbie but I have tried to make what you ask me, I have no way to check the test files. I hope you can test and find them ok. Thanks. |
|
Strict mode added |
|
Add COUNTRY_NOT_VALID exception to detect when the country is supported or not (both in VAT and TIN) |
|
Hello, have you got time to see/check this? Thanks. |
|
Hello, any news? thanks |
|
Hi @ortegafernando, Thank you so much for your patience. I've been quite busy lately. Could you quickly ensure it is also compatible with PHP 8.3 (if you can get it running with it as well as running the unit tests). This would really help me reviewing and merging your PR. Thanks very much for your help |
|
Hi @pH-7 , please dont worry, we must have patience with your github code because you develop it in your free time, dont worry please. |
Hi, I am not and expert in php, but I have found that you can complement this library with the Europe TIN check service.
It is almost the same as VIES/VAT service.
Porbably, my fork is quite bad and you can improve it a lot, but you may can use this fork for getting some pieces of codes and implement both VAT and TIN checking in one library.
Mine just works, but it is not polite.