Merged
Conversation
Owner
|
Really loving this!
|
Collaborator
Author
|
Have never worked with directories but seems doable. Side note: All file access apis are only available in the secure context (https). |
pSpitzner
force-pushed
the
fileUpload
branch
from
09d5d06 to
b1013f3
Compare
Merged
pSpitzner
pushed a commit
that referenced
this pull request
Oct 13, 2025
pSpitzner
force-pushed
the
fileUpload
branch
2 times, most recently
from
9120ac3 to
2663196
Compare
Owner
We already had most of the needed tests, also, error handling seems to work: |
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
pSpitzner
force-pushed
the
release/2.0.0
branch
from
0aa6e97 to
035cde6
Compare
semohr
force-pushed
the
release/2.0.0
branch
from
035cde6 to
0aa6e97
Compare
pSpitzner
force-pushed
the
fileUpload
branch
from
369db47 to
58fc8a5
Compare
…iles via drag and drop into the browser window or by manual selection.
tests now run through, but it still seems that our custom exceptions do not propagate through the xhr (invalid targetdir does not raise in frontend nor console log)
…ferent inbox styling.
…dling. TODO: mobile, use dialog, folder creation for multiple files, snackbar. Co-Authored-By: semohr <sebastian@mohrenclan.de>
- Added generic useDrag hook - Refactored upload into multiple files Co-authored-by: pSpitzner <github@makeitso.one>
Other dialog parts still need some work but basic functions are working. Co-authored-by: pSpitzner <github@makeitso.one>
- dialog styling - enabled dialog dropzone - excluding .git from repo permission fix a few bugs around uploading: - we can add the same file multiple times - we can add files after the upload finished :P
Structure is now flat instead of nested. Makes things easier.
pSpitzner
force-pushed
the
fileUpload
branch
from
58fc8a5 to
38434a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds file upload capabilities to our inbox view.
ToDos:
Currently, the PR breaks the dev setup - errors on dynamic reloads(seems to only occur when working on the dialog or dropzone, PS I think thats tolerable)