Added the timezone to dates when deserializing from the database.#108
Merged
Added the timezone to dates when deserializing from the database.#108
Conversation
pSpitzner
approved these changes
Jun 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #92
Datetimes do not have timezone information in sqllite. We use the server defaults
func.nowtho which always return times in utc. This PR adds timezone information to datetimes after they have be retrieved from the database, there is also a small test for it.As we never set the dates manually this approach should be fine, if we at some point decide to update dates manually we need to consider only ever writing utc times to the database..