Conversation
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
| title="Total Runtime" | ||
| icon={<TimerIcon />} | ||
| value={humanizeDuration(libraryStats.runtime)} | ||
| value={humanizeDuration(libraryStats.runtime ?? 0)} |
There was a problem hiding this comment.
This was a bug on startup: runtime is nullable.
|
Hi Brandon, Thank you so much for your contribution! I’ll take a closer look over the weekend. At first glance, it looks very promising. We might consider generalizing and abstracting some of the ideas here to enable more potential plugin integrations in the future. Overall, we’re definitely not against this and are genuinely happy when people make our project their own. Your effort is much appreciated! |
|
Hi Brandon, wanted to chime in, thanks for the praise and the PR <3 Likely after the 2.0 release is a good time, once we have the config schema validation in place #224 and switched to the debian base image #219. We will think a bit more about plugin architecture until then. best, |
|
After a bit more consideration, I've decided that I think this will be better to keep separate. I extracted my desired feature to its own standalone service: https://github.com/subdavis/bandcamp-sync-flask That way beets-flask can focus on being a really good diretory-to-beets import tool. |
fixes #237 (See the demo video)
This is just a draft, so please don't mind the mess. It's mainly to give you an idea of the scale and type of changes. IMO they're pretty well isolated from the rest of the code.
It looks like a lot, but there are only a couple of files with any real substance
Frontend