entrypoint_user_scripts.sh: ensure pip runs in venv#256
Closed
edgar-vincent wants to merge 1 commit intopSpitzner:release/2.0.0from
Closed
entrypoint_user_scripts.sh: ensure pip runs in venv#256edgar-vincent wants to merge 1 commit intopSpitzner:release/2.0.0from
edgar-vincent wants to merge 1 commit intopSpitzner:release/2.0.0from
Conversation
Collaborator
|
Thanks for the PR! As far as I know we use should use the python executable that is bundled with with the base image (even when using uv). If this is not working as expected we might have a bug in our Dockerfile. I would rather try to fix this properly in the Dockerfile than have a solution to check for virtual environment that should not exist in the first place. We had this before but it seems to be missing in the 2.0.0 version. Lines 47 to 48 in 00b246d |
Author
|
#257 fixes it here. Beautiful, thanks! |
Owner
lol. that was quick! Awesome, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 67afd94, beets runs in a venv. However,
entrypoint_user_scripts.shinstalls user-defined requirements inrequirements.txtsystem-wide via pip, which makes them inaccessible to beets.This PR makes sure the requirements are installed in the venv. It also makes sure pip is available in the pip in order to avoid silent failures.