Skip to content

should fix #69 and make the library album view load quicker #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
semohr merged 2 commits into from
Jun 10, 2025
Merged

should fix #69 and make the library album view load quicker #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeb8c5c
should fix #69 and make the library album view load quicker
pSpitzner Jun 6, 2025
ecbb35f
removed path attribute, not used actively anymore.
pSpitzner Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions backend/beets_flask/server/routes/library/resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,8 +676,6 @@ class AlbumResponseMinimal(TypedDict):
id: int
# Name of the album
name: str
# Path to the album
path: str
# Primary artist for the album
albumartist: str
# Year the album was published
Expand Down Expand Up @@ -743,8 +741,6 @@ def _rep_Album(

out: dict[str, Any] = dict()

out["path"] = beets_util.displayable_path(album.path)

if minimal:
keys = ["id", "name", "albumartist", "year", "added"]
else:
Expand Down
1 change: 0 additions & 1 deletion frontend/src/components/inbox/cards/importedCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ function AlbumInfo({ album }: { album: AlbumResponseMinimalExpanded }) {
return (
<Box>
<Box component="ul" sx={{ m: 0 }}>
<li>Path: {album.path}</li>
<li>
size:{" "}
{humanizeBytes(
Expand Down
4 changes: 0 additions & 4 deletions frontend/src/pythonTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ export interface ItemResponseMinimal {
export interface AlbumResponseMinimalExpanded {
id: number;
name: string;
path: string;
albumartist: string;
year: number;
added: Date;
Expand All @@ -238,7 +237,6 @@ export interface AlbumResponseMinimalExpanded {
export interface AlbumResponseMinimal {
id: number;
name: string;
path: string;
albumartist: string;
year: number;
added: Date;
Expand Down Expand Up @@ -285,7 +283,6 @@ export interface ItemResponse {
export interface AlbumResponseExpanded {
id: number;
name: string;
path: string;
albumartist: string;
year: number;
added: Date;
Expand All @@ -308,7 +305,6 @@ export interface AlbumSource {
export interface AlbumResponse {
id: number;
name: string;
path: string;
albumartist: string;
year: number;
added: Date;
Expand Down
9 changes: 4 additions & 5 deletions frontend/src/routes/library/(resources)/album.$albumId.route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Box, useTheme } from "@mui/material";
import { useSuspenseQuery } from "@tanstack/react-query";
import { createFileRoute, Outlet } from "@tanstack/react-router";

import { albumQueryOptions, artQueryOptions } from "@/api/library";
import { albumQueryOptions } from "@/api/library";
import { BackIconButton } from "@/components/common/inputs/back";
import { Loading } from "@/components/common/loading";
import { NavigationTabs } from "@/components/common/navigation";
Expand All @@ -28,10 +28,9 @@ export const Route = createFileRoute("/library/(resources)/album/$albumId")({
)
);

const p2 = queryClient.ensureQueryData(
artQueryOptions({ type: "album", id: params.albumId })
);
await Promise.all([p1, p2]);
// don't wait for cover-art here. we want to show main content fast
// and handle errors for artwork with ui placeholder.
await Promise.all([p1]);
},
pendingComponent: PendingComponent,
component: RouteComponent,
Expand Down
Loading