feat: add external session support and Agent tool recognition#115
Open
drewf wants to merge 1 commit intopablodelucca:mainfrom
Open
feat: add external session support and Agent tool recognition#115drewf wants to merge 1 commit intopablodelucca:mainfrom
drewf wants to merge 1 commit intopablodelucca:mainfrom
Conversation
Detect and track Claude Code sessions running in the VS Code extension panel (WebSocket transport, no terminal). These produce JSONL transcripts like terminal sessions but have no associated Terminal object. Changes: - Make terminalRef optional, add isExternal flag to AgentState - Add external session scanning (5s interval) and stale cleanup (5min timeout) - Persist/restore external agents across reloads - Guard terminal-specific code paths (focus, close, /clear reassignment) - Recognize renamed 'Agent' tool alongside 'Task' for sub-agents Known limitation: external sessions rely on JSONL file mtime for stale detection (no close event available), so agents linger up to 5 minutes after the extension panel session ends. Supersedes pablodelucca#76 and pablodelucca#77.
This was referenced Mar 12, 2026
10 tasks
|
waiting to be added to prod so much! |
|
This PR will be insane, waiting for it! |
florintimbuc
added
type: feature
|
waiting for this too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Terminalobject.Agenttool (alongsideTask) for sub-agent detection and permission exemption.Known limitations
Relation to previous PRs
This supersedes #76 (Agent tool recognition) and #77 (external session support), combining both into a single PR rebased on current
main(post-#82 formatting changes).Test plan
/clearin a terminal session reassigns correctly (doesn't affect external agents)Agenttool are recognized correctly