Merged
Conversation
Member
|
It's looks very good to me. Though, there are some blocking issues:
|
added 2 commits
September 17, 2025 10:01
Contributor
Author
|
@leleuj it should be ok now |
Member
|
I created a 6.0.x branch for the current version and merged your changes in the master. Thank you very much for your contribution. Can you update the https://github.com/pac4j/vertx-pac4j-demo before I cut the release? |
Contributor
Author
Member
|
Thanks. It's merged. I will cut the release ASAP. |
Member
|
The release has been cut and is now available in the Maven central repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request upgrades Vert.x (see #300) and pac4j.
I have removed the Rx dependency.
I created this PR because I need to upgrade Vert.x in a project that depends on vertx-pac4j.
HTH