Skip to content

upgrade vertx and pac4j#304

Merged
leleuj merged 2 commits intopac4j:masterfrom
vsct-jburet:master
Sep 17, 2025
Merged

upgrade vertx and pac4j#304
leleuj merged 2 commits intopac4j:masterfrom
vsct-jburet:master

Conversation

@vsct-jburet
Copy link
Contributor

This pull request upgrades Vert.x (see #300) and pac4j.
I have removed the Rx dependency.

I created this PR because I need to upgrade Vert.x in a project that depends on vertx-pac4j.

HTH

@leleuj
Copy link
Member

leleuj commented Sep 16, 2025

It's looks very good to me. Though, there are some blocking issues:

  • please upgrade the version to 7.0.0-SNAPSHOT in the pom.xml file as it's a new major version
  • change the JDK version to 17 in the pom.xml file but in the .github/workflows/ci.yml file as well
  • update the README.md file
  • checks that the build passes on the CI.

@vsct-jburet
Copy link
Contributor Author

@leleuj it should be ok now

@leleuj leleuj merged commit 2ebe835 into pac4j:master Sep 17, 2025
3 checks passed
@leleuj
Copy link
Member

leleuj commented Sep 17, 2025

I created a 6.0.x branch for the current version and merged your changes in the master.

Thank you very much for your contribution.

Can you update the https://github.com/pac4j/vertx-pac4j-demo before I cut the release?

@vsct-jburet
Copy link
Contributor Author

@leleuj done pac4j/vertx-pac4j-demo#264

@leleuj
Copy link
Member

leleuj commented Sep 18, 2025

Thanks. It's merged. I will cut the release ASAP.

@leleuj
Copy link
Member

leleuj commented Sep 19, 2025

The release has been cut and is now available in the Maven central repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants