Fix: correctly set user in RoutingContext by casting userContext to UserContextInternal#313
Merged
leleuj merged 1 commit intopac4j:masterfrom Nov 6, 2025
Merged
Conversation
…serContextInternal Previously, the code incorrectly cast routingContext.user() to UserContextInternal, which would fail because user() returns a User, not the internal UserContext. This fix casts routingContext.userContext() instead, allowing setUser() to work for TockUser and other auth providers.
Member
|
What exception do you get? |
Contributor
Author
|
java.lang.ClassCastException: class ai.tock.shared.security.TockUser cannot be cast to class io.vertx.ext.web.impl.UserContextInternal related PR on Tock : theopenconversationkit/tock#1939 |
Member
|
I will cut a v7.0.2 release soon. |
Member
|
The v7.0.2 has been released: it will show up very soon in the Maven central repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the code incorrectly cast routingContext.user() to UserContextInternal, which would fail because user() returns a User, not the internal UserContext. This fix casts routingContext.userContext() instead, allowing setUser() to work for TockUser and other auth providers.