Merged
Conversation
Versioningit sets the package version at build-time based on Git tags. The version attribute in pyproject.toml becomes "dynamic" rather than hard-coded. Because this is done at build-time the version is correctly set in project metadata and can be accessed by importlib. For convenience we also expose this as resins.__version__ at runtime.
Versioningit needs to see past tags in the git history to version correctly. By default the checkout action is depth=1 and doesn't pull tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Versioneer still seems to require setup.py so is perhaps not the clean modern solution we are after.
Versioningit sets the package version at build-time based on Git tags. The version attribute in pyproject.toml becomes "dynamic" rather than hard-coded.
Because this is done at build-time the version is correctly set in project metadata and can be accessed by importlib. For convenience we also expose this as
resins.__version__at runtime.I'm also applying a 0.0.1 version tag because versioneer requires some tag in the history in order to function.