Conversation
The INSTRUMENT_DATA_PATH variable becomes packaging-level information accessed via importlib. That slightly complicates the testing situation; for now we patch importlib.resources.files() as a fixture. This is a bit more risky than changing our own INSTRUMENT_DATA_PATH variable; if we run into conflict with other uses for this function then we might need to reintroduce the variable. Alternatively we could consider using an environment variable so additional paths can be set at runtime.
oerc0122
approved these changes
Jan 22, 2026
Member
Author
|
Thanks @oerc0122 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick and tidy-up of some useful things from #43.
The INSTRUMENT_DATA_PATH variable becomes packaging-level information accessed via importlib. This resolves some circular import issues encountered in #43.
It does slightly complicate the testing situation; for now we patch importlib.resources.files() as a fixture.
This is a bit more risky than changing our own INSTRUMENT_DATA_PATH variable; if we run into conflict with other uses for this function then we might need to reintroduce the variable. Alternatively we could consider using an environment variable so additional paths can be set at runtime.