fix: Don't auto-resume playback if the user scrubs media#2118
Merged
nikclayton merged 1 commit intopachli:mainfrom Feb 15, 2026
Merged
fix: Don't auto-resume playback if the user scrubs media#2118nikclayton merged 1 commit intopachli:mainfrom
nikclayton merged 1 commit intopachli:mainfrom
Conversation
Previous code was restarting playback whenever the transition had completed and the playback state moved to `STATE_READY`. This meant actions that switched from/to `STATE_READY`, like scrubbing through the media, would restart playback when complete. So pausing the video and scrubbing through the media would restart playback when scrubbing stopped. Fix this by nulling `transitionComplete` after it's been used once. Fixes pachli#2112
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code was restarting playback whenever the transition had completed and the playback state moved to
STATE_READY. This meant actions that switched from/toSTATE_READY, like scrubbing through the media, would restart playback when complete.So pausing the video and scrubbing through the media would restart playback when scrubbing stopped.
Fix this by nulling
transitionCompleteafter it's been used once.Fixes #2112