Conversation
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
@TG1999 Thanks! these should be combined in each of the existing JSON files... for instance, for tests/types/conda-validation-tests.json, merge these in https://github.com/package-url/purl-spec/blob/main/tests/types/conda-test.json
And when doing so, please make sure there is no duplicate... you also need to conform to the new schema.
TG1999
force-pushed
the
add_validation_tests
branch
2 times, most recently
from
7e01a54 to
07d9554
Compare
schemas/purl-test.schema.json
Outdated
| }, | ||
| "expected_messages": { | ||
| "title": "Expected messages", | ||
| "description": "Validation messages expected for this test. Can be null or a list of strings.", |
There was a problem hiding this comment.
Are implementations really expected to produce exactly these text messages?
There was a problem hiding this comment.
@matt-phylum re:
Are implementations really expected to produce exactly these text messages?
good point. I have mixed feeling on that alright. One part of me says it would be really nice to have the same validation error messages everywhere. One part of me says it is not critical and may put too much burden on authors. What is your preference?
TG1999
force-pushed
the
add_validation_tests
branch
2 times, most recently
from
f645ee5 to
ce67457
Compare
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
@TG1999 Thanks! see comments for your review.
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
add_validation_tests
branch
from
0124335 to
f3cc7ae
Compare
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
|
@pombredanne @TG1999 We should have an issue to discuss and approve the change to purl-test-schema.json before we apply any other changes. I will draft an Issue based on the limited information in this PR. |
|
@TG1999 It would be great if you can rebase this PR? |
There was a problem hiding this comment.
@TG1999 The proposed test cases have several examples of tests not failing even though the the URL in respository_url is not encoded. For example:
- pkg:rpm/centos/vim@8.0-1.el7?arch=x86_64&repository_url=https://mirror.centos.org/centos/7/os/x86_64
should be - pkg:rpm/centos/vim@8.0-1.el7?arch=x86_64&repository_url=https:%2F%2Fmirror.centos.org%2Fcentos%2F7%2Fos%2Fx86_64
| "parse": "A PURL building test from decoded components to a canonical PURL string.", | ||
| "roundtrip": "A PURL roundtrip test, parsing then building back a PURL from a canonical string input." | ||
| "roundtrip": "A PURL roundtrip test, parsing then building back a PURL from a canonical string input.", | ||
| "validation": "A PURL validation test, checking if a PURL follows all the rules for a particular ecosystem." |
There was a problem hiding this comment.
The definition for the new validation test_type should be: ""A test to validate that an input PURL string complies with the rules for its PURL type."
4 participants
Add tests for validating each PURL type.