Merged
Conversation
|
Preview: https://packit-dashboard-pr-504.surge.sh (deployed at Thu 16 Jan 2025, 15:31 UTC) |
There seems to be a relation to the persistent connections of the HTTP/2 (initial connection with TLS handshake is done to the dashboard; SNI is ‹dashboard.packit.dev› and with the same SNI it makes a request to the Packit Service API, thus resulting in the request being routed to the dashboard rather than the production API itself, since the routing for TLS Passthrough connections is done based on the SNI). Therefore yield 421 for each such misdirected request to force the browser to open a new connection. Fixes packit/packit-service#2529 Signed-off-by: Matej Focko <mfocko@redhat.com>
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 09s |
mfocko
force-pushed
the
fix/421-for-api-requests
branch
from
d1ab3a6 to
65e4b70
Compare
nforro
approved these changes
Jan 16, 2025
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 07s |
Venefilyn
approved these changes
Jan 16, 2025
Collaborator
Venefilyn
left a comment
Venefilyn
left a comment
There was a problem hiding this comment.
Seems like a very niche issue. Great work you both on debugging this! Code LGTM 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes packit/packit-service#2529