Skip to content

Renaming logdetective_secret to logdetective_token#3051

Merged
centosinfra-prod-github-app[bot] merged 1 commit intopackit:mainfrom
jpodivin:rename
Mar 12, 2026
Merged

Renaming logdetective_secret to logdetective_token#3051
centosinfra-prod-github-app[bot] merged 1 commit intopackit:mainfrom
jpodivin:rename

Conversation

@jpodivin
Copy link
Contributor

@jpodivin jpodivin commented Mar 12, 2026 •
edited by majamassarini
Loading

Deployment has different name in the template.

@jpodivin jpodivin requested a review from a team as a code owner March 12, 2026 13:50
@jpodivin jpodivin requested review from majamassarini and removed request for a team March 12, 2026 13:50
gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 12, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly renames logdetective_secret to logdetective_token across all relevant files, including configuration, schema, handlers, and tests. The changes are consistent and align with the goal of improving consistency with deployment templates. The implementation is correct and I have no further suggestions.

majamassarini
majamassarini approved these changes Mar 12, 2026
View reviewed changes
Copy link
Member

@majamassarini majamassarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@majamassarini majamassarini added the mergeit Merge via Zuul label Mar 12, 2026
@centosinfra-prod-github-app
Copy link
Contributor

centosinfra-prod-github-app bot commented Mar 12, 2026

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/47816d7c502b4f5aa69172a97ac6ce99

✔️ pre-commit SUCCESS in 1m 53s
✔️ packit-service-tests SUCCESS in 4m 35s

@jpodivin
Renaming logdetective_secret to logdetective_token
48b275d 
Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
@centosinfra-prod-github-app
Copy link
Contributor

centosinfra-prod-github-app bot commented Mar 12, 2026

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/b2602f08f2e041259ad5f133b97ca4b5

✔️ pre-commit SUCCESS in 1m 52s
✔️ packit-service-tests SUCCESS in 3m 55s

@centosinfra-prod-github-app
Copy link
Contributor

centosinfra-prod-github-app bot commented Mar 12, 2026

Build succeeded (gate pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/12cc5646d73a4ae0b3b5cc4b6690402c

✔️ pre-commit SUCCESS in 1m 51s

@centosinfra-prod-github-app centosinfra-prod-github-app bot merged commit 011c8f9 into packit:main Mar 12, 2026
7 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Packit pull requests Mar 12, 2026
@jpodivin jpodivin deleted the rename branch March 12, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majamassarini majamassarini majamassarini approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mergeit Merge via Zuul

Projects

Packit pull requests
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpodivin @majamassarini