-
Notifications
You must be signed in to change notification settings - Fork 54
Document sandbox limits #1081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document sandbox limits #1081
Conversation
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 02s |
docs/configuration/actions.md
Outdated
| in a sandbox environment inside Packit Service. This environment has limited resources. | ||
| Your actions shouldn't consume more than 768MiB of memory and use more than 3GiB of disk space. | ||
| Be aware that cloned upstream and dist-git repos also count towards this limit. | ||
| It is recommended to place any temporary artifacts in a subdirectory of `/tmp`, as there is no limit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit unsure about this, because the limited volume with cloned git repos is mounted at /tmp/sandcastle, which is technically also a subdirectory of /tmp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure either.
oc describe limitrange -n packit--prod-sandbox
Shows that the default limit for the storage in packit--prod-sandbox is 2Gi, I expect it to apply outside the mount point of our volume claim.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure either.
oc describe limitrange -n packit--prod-sandboxShows that the default limit for the storage inpackit--prod-sandboxis 2Gi, I expect it to apply outside the mount point of our volume claim.
That's not what I'm unsure about, there is no limit apart from node physical disk size. I suppose you are talking about the 2GiB container image size limit, which is completely irrelevant here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unsure about this too, in the cluster I can see limits.ephemeral-storage set to 10Gi, although I am not sure how exactly (if) this is being enforced, as I don't see per-pod limits for the ephermal storage. I would rather omit this part and not recommend this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to admit I didn't try to dig deeper, I just did multiple practical tests creating large files and monitoring reported free space and I haven't found a node where there would be less than 50GiB of available space outside of /tmp/sandcastle. Even if there was 10GiB limit, it's still more than 3GiB and it would solve the issue for llvm-test-suite.
But if you prefer to omit this and rather increase the PVC in case more users report struggling to fit into 3GiB, it's fine by me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thanks for the details, then I would leave it just rewrite the second part of the sentence to something like , as it serves as a non-quota-restricted space for transient files.
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 03s |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 01s |
lbarcziova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Signed-off-by: Nikola Forró <[email protected]>
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 05s |
|
regate |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 04s |
Fixes packit/packit-service#2917.