-
Notifications
You must be signed in to change notification settings - Fork 54
Document sandbox limits #1081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nforro
wants to merge
1
commit into
packit:main
Choose a base branch
from
nforro:sandcastle
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6
−3
Open
Document sandbox limits #1081
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit unsure about this, because the limited volume with cloned git repos is mounted at
/tmp/sandcastle, which is technically also a subdirectory of/tmp.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure either.
oc describe limitrange -n packit--prod-sandboxShows that the default limit for the storage in
packit--prod-sandboxis 2Gi, I expect it to apply outside the mount point of our volume claim.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not what I'm unsure about, there is no limit apart from node physical disk size. I suppose you are talking about the 2GiB container image size limit, which is completely irrelevant here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unsure about this too, in the cluster I can see
limits.ephemeral-storageset to 10Gi, although I am not sure how exactly (if) this is being enforced, as I don't see per-pod limits for the ephermal storage. I would rather omit this part and not recommend this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to admit I didn't try to dig deeper, I just did multiple practical tests creating large files and monitoring reported free space and I haven't found a node where there would be less than 50GiB of available space outside of
/tmp/sandcastle. Even if there was 10GiB limit, it's still more than 3GiB and it would solve the issue for llvm-test-suite.But if you prefer to omit this and rather increase the PVC in case more users report struggling to fit into 3GiB, it's fine by me.