fix: @types/react 17 PropsWithChildren Generic type#356
Merged
pacocoursey merged 1 commit intopacocoursey:mainfrom May 31, 2025
Merged
fix: @types/react 17 PropsWithChildren Generic type#356pacocoursey merged 1 commit intopacocoursey:mainfrom
pacocoursey merged 1 commit intopacocoursey:mainfrom
Conversation
pacocoursey
approved these changes
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An TypeScript error occurred in React 17.
Type '{ children: ReactNode; }' has no properties in common with type 'IntrinsicAttributes & ThemeProviderProps'.When I checked
"@types/react": "18.0.12"type PropsWithChildren<P = unknown> = P & { children?: ReactNode | undefined };"@types/react": "17.0.34"type PropsWithChildren<P> = P & { children?: ReactNode | undefined };So, to support React 17 version, we need to add Generic. Currently, we have no choice but to use ts-ignore because it always causes a type error.