fix: explicitly define children prop for React 19 compatibility#372
Open
jctf wants to merge 1 commit intopacocoursey:mainfrom
Open
fix: explicitly define children prop for React 19 compatibility#372jctf wants to merge 1 commit intopacocoursey:mainfrom
jctf wants to merge 1 commit intopacocoursey:mainfrom
Conversation
Fixes pacocoursey#367 React 19 changed how `PropsWithChildren` works in the type system, causing TypeScript errors when using ThemeProvider with children. This change explicitly defines the `children` prop as `React.ReactNode` instead of extending `PropsWithChildren<unknown>`, which resolves the compatibility issue while maintaining backward compatibility. The change: - Removes `extends React.PropsWithChildren<unknown>` - Adds explicit `children?: React.ReactNode` property This ensures the component works correctly with both React 18 and React 19.
floris-xlx
approved these changes
Oct 29, 2025
adeemmm23
approved these changes
Nov 13, 2025
AlexJurik
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #367
React 19 introduced changes to how
PropsWithChildrenworks in the type system, causing TypeScript errors when usingThemeProviderwith children:Solution
This PR explicitly defines the
childrenprop asReact.ReactNodeinstead of extendingPropsWithChildren<unknown>.Changes:
Backward Compatibility
This change is fully backward compatible with React 16.8+, 17, and 18:
React.ReactNodehas been stable since React 16+children?: React.ReactNodeis functionally equivalent toPropsWithChildren<unknown>in olderReact versions