Skip to content

add: rofi-x11 #8289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Elsie19 merged 1 commit into from
Dec 23, 2025
Merged

add: rofi-x11 #8289

Elsie19 merged 1 commit into from
Dec 23, 2025

Conversation

@aKqir24
Copy link
Contributor

@aKqir24 aKqir24 commented Dec 23, 2025

No description provided.

@github-actions github-actions bot added the Package Add Use this to request a package to be added label Dec 23, 2025
@aKqir24 aKqir24 marked this pull request as ready for review December 23, 2025 06:47
@aKqir24 aKqir24 force-pushed the upd-rofi-base branch 2 times, most recently from 0cd42fe to d043349 Compare December 23, 2025 14:07
Elsie19
Elsie19 requested changes Dec 23, 2025
View reviewed changes
Copy link
Member

@Elsie19 Elsie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides this, I feel like you should merge #8285 and this into one PR that has a global variable that toggles between X11 and wayland or even better, builds both!

@aKqir24
Copy link
Contributor Author

aKqir24 commented Dec 23, 2025 •
edited
Loading

Besides this, I feel like you should merge #8285 and this into one PR that has a global variable that toggles between X11 and wayland or even better, builds both!

I am currently planning on it, I still need to deal some issues related to the rofi:base conflicting depends, in which dependencies are not used and causes bloats in the system. In order to address this, I plan to put them into separate PR's, namely rofi-x11, rofi-wayland, and finally rofi(which supports both).

@aKqir24 aKqir24 marked this pull request as draft December 23, 2025 14:37
@aKqir24
add rofi-x11
fd91de0 
[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

disable test:

Rofi does not require libnkutils tests to pass to work.

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Update packages/rofi-x11/rofi-x11.pacscript

Co-authored-by: Elsie <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

test is not needed
@aKqir24 aKqir24 marked this pull request as ready for review December 23, 2025 14:56
@Elsie19 Elsie19 merged commit 9e6a9a7 into pacstall:master Dec 23, 2025
13 checks passed
tranquil-tr0 pushed a commit to tranquil-tr0/pacstall-programs that referenced this pull request Jan 7, 2026
@aKqir24 @tranquil-tr0
add: rofi-x11 (pacstall#8289)
ccd0eb5
@tranquil-tr0 tranquil-tr0 mentioned this pull request Jan 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Elsie19 Elsie19 Elsie19 approved these changes

Assignees

@aKqir24 aKqir24

Labels

Package Add Use this to request a package to be added

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aKqir24 @Elsie19