Skip to content

feat: Use content type matching rule for V3 message's binary body#5

Open
tienvx wants to merge 1 commit intopact-foundation:mainfrom
tienvx:v3-message-binary-matching-rule
Open

feat: Use content type matching rule for V3 message's binary body#5
tienvx wants to merge 1 commit intopact-foundation:mainfrom
tienvx:v3-message-binary-matching-rule

Conversation

@tienvx
Copy link
Copy Markdown
Contributor

@tienvx tienvx commented Nov 13, 2023

These scenarios didn't apply binary's content type matching rule, so the verifier will compare binary contents, byte to byte, which:

  • Is not realistic in my opinion
  • Imply that message (v3) doesn't support binary's content type matching rule at all, but it does, at least by using pactffi_with_binary_file (not sure about pactffi_message_with_contents)

@rholshausen
Copy link
Copy Markdown
Contributor

Those tables are odd. Normally we put the keys along the top.

@JP-Ellis
Copy link
Copy Markdown
Contributor

I think it's fine. He is following the same pattern as the tables below that within the same file.

@rholshausen
Copy link
Copy Markdown
Contributor

Oh, yeah, we should find whoever authored this and fire them.

@tienvx
Copy link
Copy Markdown
Contributor Author

tienvx commented Jan 21, 2026

Before I change the code, I just want to confirm: the code is okay, I only need to move the keys to the top? like this?

Before:

      | body           | file: spider.jpg                                                |
      | matching rules | contenttype-matcher-v3.json                                     |

After:

      | body           | matching rules                                                |
      |file: spider.jpg  | contenttype-matcher-v3.json                                     |

To every places in this file?

@tienvx tienvx force-pushed the v3-message-binary-matching-rule branch from 20db0b4 to 8efd6c7 Compare January 25, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants