feat: Use content type matching rule for V3 message's binary body#5
Open
tienvx wants to merge 1 commit intopact-foundation:mainfrom
Open
feat: Use content type matching rule for V3 message's binary body#5tienvx wants to merge 1 commit intopact-foundation:mainfrom
tienvx wants to merge 1 commit intopact-foundation:mainfrom
Conversation
e33a009 to
20db0b4
Compare
This was referenced Dec 20, 2023
Contributor
|
Those tables are odd. Normally we put the keys along the top. |
Contributor
|
I think it's fine. He is following the same pattern as the tables below that within the same file. |
Contributor
|
Oh, yeah, we should find whoever authored this and fire them. |
Contributor
Author
|
Before I change the code, I just want to confirm: the code is okay, I only need to move the keys to the top? like this? Before: After: To every places in this file? |
20db0b4 to
8efd6c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These scenarios didn't apply binary's content type matching rule, so the verifier will compare binary contents, byte to byte, which:
pactffi_with_binary_file(not sure aboutpactffi_message_with_contents)