Skip to content

Fixes the problem when sum of split's amounts is not equal to the order total amount #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
douglasfanucchi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes the problem when sum of split's amounts is not equal to the order total amount #170

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fec56cf
fix: changes calculation of main recipient commission
douglasfanucchi Dec 15, 2024
7a97460
set main recipient commision before parsing it to request object
douglasfanucchi Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions src/Payment/Aggregates/Payments/AbstractPayment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,22 +81,8 @@ protected function getSplitData()
return null;
}
$percentageOfPayment = $this->getAmount() / $this->order->getAmount();
$splitMainRecipient = new Split();

$marketplaceCommission = intval(
round(
$splitOrderData->getMarketplaceComission() * $percentageOfPayment
)
);

$splitMainRecipient->setCommission(
$marketplaceCommission
);

$splitMainRecipient->setRecipientId($this->moduleConfig->getMarketplaceConfig()->getMainRecipientId());
$splitMainRecipientRequest = $splitMainRecipient
->convertMainToSDKRequest();

$sellersTotalCommission = 0;
foreach ($splitOrderData->getSellersData() as $seller) {
$splitRecipient = new Split();

Expand All @@ -106,12 +92,24 @@ protected function getSplitData()
)
);

$sellersTotalCommission += $sellerCommission;

$splitRecipient->setCommission($sellerCommission);
$splitRecipient->setRecipientId($seller['pagarmeId']);
$splitRecipientRequests[] = $splitRecipient
->convertSecondaryToSDKRequest();
}

$splitMainRecipient = new Split();

$splitMainRecipient->setCommission(
$this->getAmount() - $sellersTotalCommission
);

$splitMainRecipient->setRecipientId($this->moduleConfig->getMarketplaceConfig()->getMainRecipientId());
$splitMainRecipientRequest = $splitMainRecipient
->convertMainToSDKRequest();

return [$splitMainRecipientRequest, $splitRecipientRequests];
}

Expand Down