This repository was archived by the owner on Jan 13, 2026. It is now read-only.
Open
Conversation
|
@davidpvilaca Antes de tudo gostaria muito de agradecer pela sua contribuição!!! Tenho alguns pontos de ressalva para ponderar nela:
Proponho quebrar essa pr nos seguintes pontos:
Por fim tem que mudar esse descritivo da PR. 😄 Se seguir nessa ordem as mudanças acho que fica bem legal. |
murilohns
suggested changes
Mar 5, 2021
| const stringify = log => { | ||
| if (R.is(String, log)) return log | ||
| export const stringify = (log: any) => { | ||
| if (typeof log === 'string') return log |
Contributor
There was a problem hiding this comment.
Fala @davidpvilaca, talvez isso aqui dê problema. 🤔
Manter o comportamento com Ramda tanto aqui, quanto nos outros locais modificados dessa forma é mais seguro
| @@ -0,0 +1,25 @@ | |||
| const { compilerOptions } = require('./tsconfig.json') | |||
Contributor
There was a problem hiding this comment.
Obrigado por colocar Jest 😍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This close #73
Proposed Changes
Motivation and Context
As I said in issue #73 I am using a scribe and I already had to write some types at the root of the my project to get rid of using "any" in everything related to this library.
How Has This Been Tested?
npm run lintnpm testnpm run build(dist folder checked with .d.ts files)Impactful Changes
Any change or improvement to approve this PR, I am ready to listen