Change vars to let or const in boleto.js, formatter.js and edi-helper.js#32
Open
felipeemarcon wants to merge 3 commits intopagarme:masterfrom
Open
Change vars to let or const in boleto.js, formatter.js and edi-helper.js#32felipeemarcon wants to merge 3 commits intopagarme:masterfrom
felipeemarcon wants to merge 3 commits intopagarme:masterfrom
Conversation
lucianopf
requested review from
Thor99,
alinemarjorie,
jeanaugustoos and
lucianopf
Thor99
reviewed
Oct 2, 2019
Contributor
Thor99
left a comment
Thor99
left a comment
There was a problem hiding this comment.
MUITO obrigado pelo PR!!! Seguem algumas sugestões de estilo :D
| let cents = exports.addTrailingZeros( | ||
| amount.substring(amount.length - 2, amount.length), | ||
| 2 | ||
| ) |
Contributor
There was a problem hiding this comment.
O que acha de quebrar uma linha entre essas declarações (cents e integers)?
| const startDate = moment('1997-10-07').utc().format('YYYY-MM-DD') | ||
| const parsedDate = moment(date) | ||
| .utc() | ||
| .format('YYYY-MM-DD') |
Contributor
There was a problem hiding this comment.
O que acha de quebrar uma linha entre essas declarações (parsedDate e startDate)?
alinemarjorie
previously approved these changes
Oct 3, 2019
Thor99
approved these changes
Oct 8, 2019
igorantun
approved these changes
Oct 8, 2019
lucianopf
approved these changes
Nov 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As variáveis
varsforam trocadas paraletouconstdependendo do contexto.