Skip to content

Fix 'Attempt to read property metadata on null' in Webhooks controller #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
proteusbr1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix 'Attempt to read property metadata on null' in Webhooks controller #586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Controller/Webhooks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ public function handle_requests()
$this->config->log()->info('Webhook Received: empty body!');
return;
}
if (!$this->orderByWoocommerce($body->data->code, $body->data->order->metadata, $body->id) ) {
$code = $body->data->code ?? null;
$metadata = $body->data->order->metadata ?? null;
Comment on lines +64 to +65
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The null coalescing operator only protects against the final property being null, not intermediate properties. If $body->data is null, this will still produce a "Attempt to read property on null" warning. Consider using the nullsafe operator ?-> instead, or check if $body->data exists first. For example: $code = $body->data?->code ?? null; and $metadata = $body->data?->order?->metadata ?? null;

Copilot uses AI. Check for mistakes.

if (!$this->orderByWoocommerce($code, $metadata, $body->id) ) {
return;
}

Expand Down
Loading