balance: Additional TM compatibility fixes#7130
Draft
Blitz425 wants to merge 1 commit intopagefaultgames:betafrom
Draft
balance: Additional TM compatibility fixes#7130Blitz425 wants to merge 1 commit intopagefaultgames:betafrom
Blitz425 wants to merge 1 commit intopagefaultgames:betafrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Elekid can learn Focus Blast, Swellow can learn Hurricane.
Why am I making these changes?
The original method of parsing TMs were done rather poorly, and we are still cleaning up the file after all this time thanks to the help of our community pointing out these oddities. Taillow was able to learn Hurricane but not Swellow for whatever reason.
What are the changes from a developer perspective?
Added lines to the behemoth of a file that is tm-species-map
If anyone would like to completely refactor the file and reparse TMs so we can catch all these oddities, that would be GREATLY appreciated. This file is terrible to navigate and add to.
Screenshots/Videos
How to test the changes?
Check Pokedex
Checklist
betaas my base branchbeta,mainor the name of another long-lived feature branchpnpm test:silentto test locally)pnpm test:create) or updated existing tests related to the PR's changes if necessaryAre there any localization additions or changes? If so:
Does this require any additions or changes to in-game assets? If so: