refactor(audio): move biome BGM loop points to assets submodule#7134
Merged
damocleas merged 5 commits intopagefaultgames:betafrom Mar 8, 2026
Merged
refactor(audio): move biome BGM loop points to assets submodule#7134damocleas merged 5 commits intopagefaultgames:betafrom
damocleas merged 5 commits intopagefaultgames:betafrom
Conversation
damocleas
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
N/A
Why am I making these changes?
Requested. Should make modifying biome BGM easier in the future.
What are the changes from a developer perspective?
Biome BGM loop points moved out of the biome definitions and into a JSON file in the assets submodule.
Checklist
betaas my base branchbeta,mainor the name of another long-lived feature branchDoes this require any additions or changes to in-game assets? If so: