Skip to content

refactor(audio): move biome BGM loop points to assets submodule#7134

Merged
damocleas merged 5 commits intopagefaultgames:betafrom
DayKev:dev/move-biome-bgm-loop-points
Mar 8, 2026
Merged

refactor(audio): move biome BGM loop points to assets submodule#7134
damocleas merged 5 commits intopagefaultgames:betafrom
DayKev:dev/move-biome-bgm-loop-points

Conversation

@DayKev
Copy link
Collaborator

@DayKev DayKev commented Mar 3, 2026

What are the changes the user will see?

N/A

Why am I making these changes?

Requested. Should make modifying biome BGM easier in the future.

What are the changes from a developer perspective?

Biome BGM loop points moved out of the biome definitions and into a JSON file in the assets submodule.

Checklist

  • The PR content is correctly formatted:
    • I'm using beta as my base branch
    • The current branch is not named beta, main or the name of another long-lived feature branch
    • I have provided a clear explanation of the changes within the PR description
    • The PR title matches the Conventional Commits format (as described in CONTRIBUTING.md)
  • The PR is self-contained and cannot be split into smaller PRs
  • There is no overlap with another open PR
  • The PR has been confirmed to work correctly:
    • I have tested the changes manually

Does this require any additions or changes to in-game assets? If so:

@DayKev DayKev added Refactor Rewriting existing code related Audio Relates to the SFX or BGM Awaiting Assets This PR makes changes to assets and should not be merged until the matching assets PR is ready labels Mar 3, 2026
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request is blocked until the associated assets PR is merged.
To unblock and update the assets submodule, add the Update Assets label.

@DayKev DayKev marked this pull request as ready for review March 3, 2026 08:35
@DayKev DayKev requested review from a team as code owners March 3, 2026 08:35
@damocleas damocleas added the Update Assets Update the Assets Submodule automatically label Mar 3, 2026
@github-actions github-actions bot removed Update Assets Update the Assets Submodule automatically Awaiting Assets This PR makes changes to assets and should not be merged until the matching assets PR is ready labels Mar 3, 2026
@github-actions github-actions bot dismissed their stale review March 3, 2026 16:24

Assets updated, unblocking PR.

@damocleas damocleas merged commit 6b22698 into pagefaultgames:beta Mar 8, 2026
13 checks passed
@DayKev DayKev deleted the dev/move-biome-bgm-loop-points branch March 8, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Audio Relates to the SFX or BGM Refactor Rewriting existing code related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants