Skip to content

i18n: Translatable "Score" label#7137

Merged
DayKev merged 3 commits intopagefaultgames:betafrom
Adri1:score-ui-transaltion
Mar 5, 2026
Merged

i18n: Translatable "Score" label#7137
DayKev merged 3 commits intopagefaultgames:betafrom
Adri1:score-ui-transaltion

Conversation

@Adri1
Copy link
Contributor

@Adri1 Adri1 commented Mar 4, 2026

What are the changes the user will see?

Translated "Score:" label in battle UI

Why am I making these changes?

To have it translatable

What are the changes from a developer perspective?

--

Screenshots/Videos

Before (French) image
After (French) image

How to test the changes?

--

Checklist

  • The PR content is correctly formatted:
    • I'm using beta as my base branch
    • The current branch is not named beta, main or the name of another long-lived feature branch
    • I have provided a clear explanation of the changes within the PR description
    • The PR title matches the Conventional Commits format (as described in CONTRIBUTING.md)
  • The PR is self-contained and cannot be split into smaller PRs
  • There is no overlap with another open PR
  • The PR has been confirmed to work correctly:
    • I have tested the changes manually
    • The full automated test suite still passes (use pnpm test:silent to test locally)
    • I have created new automated tests (pnpm test:create) or updated existing tests related to the PR's changes if necessary
  • I have provided screenshots/videos of the changes (if applicable)
    • I have made sure that any UI changes work for both the default and legacy UI themes (if applicable)

Are there any localization additions or changes? If so:

@Adri1 Adri1 requested a review from a team as a code owner March 4, 2026 14:27
@Adri1 Adri1 requested review from DayKev, Wlowscha and xsn34kzx March 4, 2026 14:27
DayKev
DayKev previously approved these changes Mar 4, 2026
fabske0
fabske0 previously approved these changes Mar 4, 2026
Bertie690
Bertie690 previously approved these changes Mar 4, 2026
@Bertie690 Bertie690 dismissed stale reviews from fabske0, DayKev, and themself via 9973531 March 4, 2026 15:46
@Bertie690
Copy link
Contributor

@DayKev Requesting bypass merge

@Madmadness65 Madmadness65 added the Localization Provides or updates translation efforts label Mar 5, 2026
@DayKev DayKev merged commit 33059e4 into pagefaultgames:beta Mar 5, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Localization Provides or updates translation efforts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants