refactor(ui): change placement of option labels in challenge select#7142
Merged
DayKev merged 2 commits intopagefaultgames:betafrom Mar 9, 2026
Merged
refactor(ui): change placement of option labels in challenge select#7142DayKev merged 2 commits intopagefaultgames:betafrom
DayKev merged 2 commits intopagefaultgames:betafrom
Conversation
82e2d7e to
46405d1
Compare
Challenge option labels are now right-aligned with the right arrow, and the left arrow's position is dynamically updated to be left of the option label
46405d1 to
06284e3
Compare
fabske0
approved these changes
Mar 8, 2026
SirzBenjie
approved these changes
Mar 8, 2026
Member
|
It looks better before, but yeah... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
The option labels and left arrow are dynamically placed based on the actual length of the option text, rather than fixed based on the option with the longest text, and the padding between the right arrow and the border was set to a fixed distance for all languages (generally results in a reduction).
Why am I making these changes?
The current method was causing unnecessary text overlapping.
What are the changes from a developer perspective?
Screenshots/Videos
Before
After
Checklist
betaas my base branchbeta,mainor the name of another long-lived feature branch