Skip to content

refactor(ui): change placement of option labels in challenge select#7142

Merged
DayKev merged 2 commits intopagefaultgames:betafrom
DayKev:refactor/challenge-select-ui
Mar 9, 2026
Merged

refactor(ui): change placement of option labels in challenge select#7142
DayKev merged 2 commits intopagefaultgames:betafrom
DayKev:refactor/challenge-select-ui

Conversation

@DayKev
Copy link
Collaborator

@DayKev DayKev commented Mar 7, 2026

What are the changes the user will see?

The option labels and left arrow are dynamically placed based on the actual length of the option text, rather than fixed based on the option with the longest text, and the padding between the right arrow and the border was set to a fixed distance for all languages (generally results in a reduction).

Why am I making these changes?

The current method was causing unnecessary text overlapping.

What are the changes from a developer perspective?

  • The right arrow is now fixed relative to the container border instead of dynamic based on the longest option text.
  • The left arrow is dynamic, placed a fixed spacing to the left of the option text.
  • The option text is right-aligned within the left and right arrows.
  • The padding between the right arrow and the container border is fixed.
  • A console warning is added to notify if there is potential text overlap due to a challenge name + option text combination being too long.

Screenshots/Videos

Before image
After image

Checklist

  • The PR content is correctly formatted:
    • I'm using beta as my base branch
    • The current branch is not named beta, main or the name of another long-lived feature branch
    • I have provided a clear explanation of the changes within the PR description
    • The PR title matches the Conventional Commits format (as described in CONTRIBUTING.md)
  • The PR is self-contained and cannot be split into smaller PRs
  • There is no overlap with another open PR
  • The PR has been confirmed to work correctly:
    • I have tested the changes manually

@DayKev DayKev added UI/UX User interface/-experience related Refactor Rewriting existing code related labels Mar 7, 2026
@DayKev DayKev force-pushed the refactor/challenge-select-ui branch from 82e2d7e to 46405d1 Compare March 7, 2026 09:42
Challenge option labels are now right-aligned with the right arrow,
and the left arrow's position is dynamically updated
to be left of the option label
@DayKev DayKev force-pushed the refactor/challenge-select-ui branch from 46405d1 to 06284e3 Compare March 7, 2026 10:44
@DayKev DayKev marked this pull request as ready for review March 7, 2026 22:49
@DayKev DayKev requested a review from a team as a code owner March 7, 2026 22:49
@DayKev DayKev requested review from Bertie690, Xavion3 and emdeann March 7, 2026 22:49
@SirzBenjie
Copy link
Member

It looks better before, but yeah...

@DayKev DayKev merged commit 1678027 into pagefaultgames:beta Mar 9, 2026
13 checks passed
@DayKev DayKev deleted the refactor/challenge-select-ui branch March 9, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Rewriting existing code related UI/UX User interface/-experience related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants