Skip to content

feat: Update Docker login action and fix token handling #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegoitaliait merged 7 commits into from
Nov 6, 2025
Merged

feat: Update Docker login action and fix token handling #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9471a39
added secrets to snapshot docker
diegoitaliait Nov 6, 2025
a9dd8de
minor fix
diegoitaliait Nov 6, 2025
1a35828
fix: update docker/login-action version to v3.6.0
diegoitaliait Nov 6, 2025
ac8f3a1
fix: correct token variable name and re-order login step in action.yml
diegoitaliait Nov 6, 2025
749d30f
mirnof xi
diegoitaliait Nov 6, 2025
f6b537c
fix: correct Docker tags output for non-workflow dispatch events
diegoitaliait Nov 6, 2025
f3d6007
fix: standardize token variable name to GIT_AUTH_TOKEN in action.yml
diegoitaliait Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions payments-flow-docker-snapshot/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ inputs:
maintainer=https://pagopa.it
org.opencontainers.image.source=https://github.com/${{ github.repository }}


runs:
using: "composite"
steps:
Expand All @@ -25,18 +26,13 @@ runs:
shell: bash
run: |
if [ -n "${{ inputs.github_pat }}" ]; then
echo "GITHUB_AUTH_TOKEN=${{ inputs.github_pat }}" >> $GITHUB_OUTPUT
echo "ℹ️ Using personal GitHub PAT token"
echo "GIT_AUTH_TOKEN=${{ inputs.github_pat }}" >> $GITHUB_OUTPUT
else
echo "GITHUB_AUTH_TOKEN=${{ github.token }}" >> $GITHUB_OUTPUT
echo "ℹ️ Using default GitHub token"
echo "GIT_AUTH_TOKEN=${{ github.token }}" >> $GITHUB_OUTPUT
fi

- name: 🛃 Log in to the Github Container registry
uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ steps.set_token.outputs.GITHUB_AUTH_TOKEN }}

- name: 🤔 Set Docker tags
id: set_docker_tags
shell: bash
Expand All @@ -47,12 +43,21 @@ runs:
echo "DOCKER_TAGS=ghcr.io/${{ github.repository }}:snapshot,ghcr.io/${{ github.repository }}:snapshot-${{ inputs.current_branch }}" >> $GITHUB_OUTPUT
fi

- name: 🛃 Log in to the Github Container registry
# https://github.com/docker/login-action/releases/tag/v3.6.0
uses: docker/login-action@5e57cd118135c172c3672efd75eb46360885c0ef
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ steps.set_token.outputs.GIT_AUTH_TOKEN }}

- name: 🚀 Build and push Docker image
uses: docker/build-push-action@4f58ea79222b3b9dc2c8bbdd6debcef730109a75
uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 # v6.18.0
with:
context: .
push: true
tags: ${{ steps.set_docker_tags.outputs.DOCKER_TAGS }}
labels: ${{ inputs.docker_labels }}
build-args: |
GITHUB_TOKEN=${{ steps.set_token.outputs.GITHUB_AUTH_TOKEN }}
platforms: linux/amd64
build-args: GIT_AUTH_TOKEN=${{ steps.set_token.outputs.GIT_AUTH_TOKEN }}
secrets: GIT_AUTH_TOKEN=${{ steps.set_token.outputs.GIT_AUTH_TOKEN }}
17 changes: 10 additions & 7 deletions payments-flow-release/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,16 @@ runs:
shell: bash
run: |
if [ -n "${{ inputs.github_pat }}" ]; then
echo "GITHUB_AUTH_TOKEN=${{ inputs.github_pat }}" >> $GITHUB_OUTPUT
echo "GIT_AUTH_TOKEN=${{ inputs.github_pat }}" >> $GITHUB_OUTPUT
else
echo "GITHUB_AUTH_TOKEN=${{ github.token }}" >> $GITHUB_OUTPUT
echo "GIT_AUTH_TOKEN=${{ github.token }}" >> $GITHUB_OUTPUT
fi

- name: 🚀 Release
id: release
uses: pagopa/eng-github-actions-iac-template/global/release-action@main
with:
github_token: ${{ steps.set_token.outputs.GITHUB_AUTH_TOKEN }}
github_token: ${{ steps.set_token.outputs.GIT_AUTH_TOKEN }}
tag_format: ${{ steps.set-tag-format.outputs.TAG_FORMAT }}
branches: ${{ github.ref_name }}

Expand All @@ -76,20 +76,23 @@ runs:
- name: 🛃 Log in to the Github Container registry
id: docker_login
if: steps.release.outputs.new_release_published == 'true' && inputs.docker_build == 'true'
uses: docker/login-action@0d4c9c5ea7693da7b068278f7b52bda2a190a446 #v3.2.0
# https://github.com/docker/login-action/releases/tag/v3.6.0
uses: docker/login-action@5e57cd118135c172c3672efd75eb46360885c0ef
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ steps.set_token.outputs.GITHUB_AUTH_TOKEN }}
password: ${{ steps.set_token.outputs.GIT_AUTH_TOKEN }}

- name: 📦 Build and push Docker image with release version
id: docker_build_push
if: steps.release.outputs.new_release_published == 'true' && inputs.docker_build == 'true'
uses: docker/build-push-action@1a162644f9a7e87d8f4b053101d1d9a712edc18c #v6.3.0
uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 # v6.18.0
with:
context: .
push: true
tags: ${{ steps.set_docker_tags.outputs.DOCKER_TAGS }}
labels: ${{ inputs.docker_labels }}
build-args: |
GITHUB_TOKEN=${{ steps.set_token.outputs.GITHUB_AUTH_TOKEN }}
GIT_AUTH_TOKEN=${{ steps.set_token.outputs.GIT_AUTH_TOKEN }}
secrets: |
GIT_AUTH_TOKEN=${{ steps.set_token.outputs.GIT_AUTH_TOKEN }}