fix: Saml response multiple signatures check#865
Merged
giuseppe-gangemi merged 16 commits intomainfrom Sep 30, 2025
Merged
Conversation
giuseppe-gangemi
force-pushed
the
fix/oi-478-saml-response-multiple-signatures-check
branch
from
4844a98 to
35bf21b
Compare
giuseppe-gangemi
had a problem deploying
to
prod/eu-central-1
GitHub Actions
Failure
giuseppe-gangemi
temporarily deployed
to
uat
GitHub Actions
Inactive
giuseppe-gangemi
temporarily deployed
to
dev
GitHub Actions
Inactive
giuseppe-gangemi
had a problem deploying
to
prod/eu-south-1
GitHub Actions
Failure
giuseppe-gangemi
temporarily deployed
to
dev
GitHub Actions
Inactive
giuseppe-gangemi
temporarily deployed
to
dev
GitHub Actions
Inactive
sebbalex
previously approved these changes
Sep 24, 2025
giuseppe-gangemi
dismissed stale reviews from sebbalex and BenitoVisone
via
0afef0d
giuseppe-gangemi
temporarily deployed
to
dev
GitHub Actions
Inactive
giuseppe-gangemi
temporarily deployed
to
dev
GitHub Actions
Inactive
giuseppe-gangemi
temporarily deployed
to
dev
GitHub Actions
Inactive
giuseppe-gangemi
force-pushed
the
fix/oi-478-saml-response-multiple-signatures-check
branch
from
2aa01b2 to
a7d9724
Compare
giuseppe-gangemi
had a problem deploying
to
prod/eu-south-1
GitHub Actions
Failure
giuseppe-gangemi
temporarily deployed
to
dev
GitHub Actions
Inactive
giuseppe-gangemi
had a problem deploying
to
prod/eu-central-1
GitHub Actions
Failure
giuseppe-gangemi
temporarily deployed
to
uat
GitHub Actions
Inactive
giuseppe-gangemi
temporarily deployed
to
dev
GitHub Actions
Inactive
giuseppe-gangemi
force-pushed
the
fix/oi-478-saml-response-multiple-signatures-check
branch
from
a7d9724 to
3549bb3
Compare
giuseppe-gangemi
temporarily deployed
to
uat
GitHub Actions
Inactive
giuseppe-gangemi
temporarily deployed
to
prod/eu-south-1
GitHub Actions
Inactive
giuseppe-gangemi
temporarily deployed
to
dev
GitHub Actions
Inactive
giuseppe-gangemi
temporarily deployed
to
prod/eu-central-1
GitHub Actions
Inactive
giuseppe-gangemi
temporarily deployed
to
dev
GitHub Actions
Inactive
giuseppe-gangemi
temporarily deployed
to
dev
GitHub Actions
Inactive
|
sebbalex
approved these changes
Sep 30, 2025
giuseppe-gangemi
deleted the
fix/oi-478-saml-response-multiple-signatures-check
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
List of Changes
Signatureinside theAssertionorResponseelement.The invalid Samlresponse with multiple signatures will be stored inside the
SAMLsession record on dynamoDB, but the authetication flow will be interrupted.NB: this pr doesn't activate the constraint, in this stage in case of SAMLResponse with multiple signature, a metric is sent to cloudwatch. The blocking of auth flow will be introduced after a period of monitoring.
Related Task
How Has This Been Tested?
Screenshots (if appropriate)