Conversation
|
https://github.com/visch/sshtunnel/actions/runs/4765659882/jobs/8471681007?pr=2 This PR fixes the issue with the SSH server not spinng up properly. The leftover issue is in |
|
e2e tests passing see https://github.com/visch/sshtunnel/actions/runs/4765854722/jobs/8472114990 |
|
What about python2 compatibility? |
I didn't want to mess with it due to actions/runner-images#7401 , do you think it's worth rolling our own here to support 2.*? I also assumed (wrongly) that I can add it in if you'd like! |
https://github.com/visch/sshtunnel/actions/runs/4949001204 Added Python 2.7 support to the action |
|
Your work looks good to me. Could you please resolve the conflicts? It would be better to migrate from CircleCI to GitHub Actions for testing different Python versions. |
|
Do you have time to continue your work? |
I didn't, I should be able to come back to this at some point :O might be a little bit |
Wanted ssh tunnel functionality for MeltanoLabs/tap-postgres#94
Also wanted to test so I used the existing e2e tests, unfortunately a number of broken things in there so this should address most of the. We should probably refactor this as well, but at least they work now!