Skip to content

Fixed empty ssh password case. #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adrianlasota wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed empty ssh password case. #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sshtunnel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,7 +1165,7 @@ def _consolidate_auth(ssh_password=None,
if isinstance(ssh_pkey, paramiko.pkey.PKey):
ssh_loaded_pkeys.insert(0, ssh_pkey)

if not ssh_password and not ssh_loaded_pkeys:
if ssh_password is None and not ssh_loaded_pkeys:
raise ValueError('No password or public key available!')
return (ssh_password, ssh_loaded_pkeys)

Expand Down Expand Up @@ -1410,7 +1410,7 @@ def _connect_to_gateway(self):
self.logger.debug('Authentication error')
self._stop_transport()

if self.ssh_password: # avoid conflict using both pass and pkey
if self.ssh_password is not None: # avoid conflict using both pass and pkey
self.logger.debug('Trying to log in with password: {0}'
.format('*' * len(self.ssh_password)))
try:
Expand Down