Open
Conversation
The `newline` code removed here generated an extra `|` character at the break between constants-for-base-units and constants-for-derived-units. This corrupted the display in the rendered table; all the derived-unit constants were not rendered into the table, but rendered as text. Don't print the extra `|`. With this, all the constants show up in one table.
As of 1.66, Clippy lints on `"{}", d` instead of `"{d}"`.
However, this behavior is only available as of 1.58-
which postdates the 2021 edition (launched in 1.56).
Ignore the lint, to maintain a lower minimum supported Rust version.
Author
|
Added some commits to fix the lints that Clippy turned up. The "uninlined variables" one would more properly be addressed by setting an MSRV; working on a separate PR for that. |
Owner
|
CI hasn't been run in a while; I'm not surprised it needs some love. I appreciate any passes you take at it, but don't feel you need to to get this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
newlinecode removed here generated an extra|character at the break between constants-for-base-units and constants-for-derived-units. This corrupted the display in the rendered table; all the derived-unit constants were not rendered into the table, but rendered as text.Don't print the extra
|. With this, all the constants show up in one table.Before:
After: