commit ruby project #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikegee
reviewed
Jun 17, 2017
| end | ||
|
|
||
| it "Yes, it is a Object, but which" do | ||
| expect(1.is_a? _fill_in_object_).to be true | ||
| expect(1.is_a? Fixnum).to be true |
There was a problem hiding this comment.
Integer is preferred here. Fixnum and Bignum are removed from Ruby 2.4+
https://www.ruby-lang.org/en/news/2016/12/25/ruby-2-4-0-released/
mikegee
reviewed
Jun 17, 2017
| end | ||
|
|
||
| it "adds an item to the front of an array" do | ||
| expect([1]._fill_in_method_here_("banana")).to eq ["banana", 1] | ||
| expect([1].insert(1, "banana")).to eq [1, "banana"] |
There was a problem hiding this comment.
Don't change the expected value. Only fill in a method that makes it work as written.
|
Pretty good apart from a couple nitpicks. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jaybobo @jack-chester