Deserialize enum variants case-insensitively #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
Author
|
Note that after this lands, we may also want to backport to 1.x |
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
1 similar comment
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The conjure spec requires that enum variants be uppercase. The conjure wire spec doesn't specify casing (as far as I saw). The Java implementation is case-insensitive on deserializing enum variants: https://github.com/palantir/conjure-java/blob/6.65.0/conjure-java-core/src/main/java/com/palantir/conjure/java/types/EnumGenerator.java#L240-L276. As such, some clients of conjure APIs currently use lower-case enum variants, which work with Java server implementations.
After this PR
==COMMIT_MSG==
Deserialize enum variants case-insensitively, for compatibility with the Java implementation
==COMMIT_MSG==
Possible downsides?