Skip to content

Conversation

@Rkuro
Copy link

@Rkuro Rkuro commented Dec 21, 2022

Before this PR

If I had an object that looked like this:

{
"foo-bar": "baz"
}

There is no way currently to deserialize this as a conjure object since the naming for conjure is limited to PascalCase and then converted from PascalCase to snake case, i.e. "FooBar" -> "foo_bar" which means that when we hit the decoder case we are silently missing the cases where it is "foo-bar" and I think this should be a capability of the library :)

After this PR

==COMMIT_MSG==
Allow hyphens to be deserialized into conjure objects (non-default)
==COMMIT_MSG==

Possible downsides?

@Rkuro
Copy link
Author

Rkuro commented Dec 21, 2022

changelog bot seems to be having trouble picking up the output of the form ^ - adding no-changelog as a workaround.

@Rkuro Rkuro changed the title Allow hyphens when decoding from json Feature: DecodingOptions to allow non-default behavior overrides (e.g. less strict deserialization) Dec 22, 2022
@Rkuro Rkuro changed the title Feature: DecodingOptions to allow non-default behavior overrides (e.g. less strict deserialization) Feature: Introduce DecodingOptions to allow non-default behavior overrides (e.g. less strict deserialization) Dec 22, 2022
@stale
Copy link

stale bot commented Jun 27, 2025

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

1 similar comment
@stale
Copy link

stale bot commented Oct 18, 2025

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

@stale stale bot added the stale label Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant