Skip to content

Fix deadlines deprecation#2710

Closed
aldexis wants to merge 3 commits intodevelopfrom
ald/fix-deadlines-deprecation
Closed

Fix deadlines deprecation#2710
aldexis wants to merge 3 commits intodevelopfrom
ald/fix-deadlines-deprecation

Conversation

@aldexis
Copy link
Contributor

@aldexis aldexis commented Sep 29, 2025

Before this PR

InlineMeInliner does not get auto-applied yet. Instead, it gets suppressed, as in #2704, which means that the annotation added in https://github.com/palantir/deadlines-java/pull/188/files#diff-f8f90c9951b97fc3abe992cb927e3601222e7e3ce25efb471821039feab57432R179-R181 doesn't get auto-fixed

After this PR

==COMMIT_MSG==
Fix deadlines deprecation
==COMMIT_MSG==

Possible downsides?

@kunalrkak
Copy link
Contributor

@aldexis this will be updated to the new method in #2681 when that PR merges shortly / it should be okay to just leave in the suppression until then. A larger question is should we keep the InlineMeInliner annotation in deadlines-java if it doesn't get auto-applied?

@aldexis aldexis closed this Oct 1, 2025
@aldexis aldexis deleted the ald/fix-deadlines-deprecation branch October 1, 2025 09:07
@aldexis aldexis restored the ald/fix-deadlines-deprecation branch October 13, 2025 09:18
@aldexis aldexis reopened this Oct 13, 2025
@aldexis aldexis closed this Oct 17, 2025
@aldexis aldexis deleted the ald/fix-deadlines-deprecation branch October 17, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants