[Alternate] Configure deadline enforcement for dialogue clients#2723
Closed
[Alternate] Configure deadline enforcement for dialogue clients#2723
Conversation
added 3 commits
October 1, 2025 15:53
Generate changelog in
|
added 2 commits
October 1, 2025 18:04
kunalrkak
commented
Oct 2, 2025
dialogue-clients/src/main/java/com/palantir/dialogue/clients/ReloadingClientFactory.java
Outdated
Show resolved
Hide resolved
kunalrkak
commented
Oct 3, 2025
| assertThat(getCacheSize(cache)).isEqualTo(1); | ||
| } | ||
|
|
||
| // Reflection hackery below |
Contributor
Author
There was a problem hiding this comment.
Basically wanted to test things related to the underlying channels and confirm we were using a cached channel for new instances with the same config - let me know if this is overkill for tests though / if I'm overcomplicating
Contributor
Author
|
Ended up sticking with the original implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
Proposes an alternative implementation to #2681
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?