Make BaselineModuleJvmArgs Configuration-Cache friendly#3202
Open
kelvinou01 wants to merge 1 commit intodevelopfrom
Open
Make BaselineModuleJvmArgs Configuration-Cache friendly#3202kelvinou01 wants to merge 1 commit intodevelopfrom
BaselineModuleJvmArgs Configuration-Cache friendly#3202kelvinou01 wants to merge 1 commit intodevelopfrom
Conversation
Contributor
|
can we get a test case for this? |
FinlayRJW
reviewed
Aug 14, 2025
| }); | ||
|
|
||
| Provider<ImmutableList<JarManifestModuleInfo>> classpathInfo = | ||
| project.provider(() -> collectClasspathInfoForSourceSet(sourceSet)); |
Contributor
There was a problem hiding this comment.
Rather than wrapping this in a provider can we just make collectClasspathInfoForSourceSet return a provider - something like this should work I think:
return classpath.getElements().map(fileSystemLocations -> fileSystemLocations.stream()
.map(FileSystemLocation::getAsFile)
.map(file -> { ... }))|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
Contributor
Author
|
no! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
We are trying to get our repositories to run
classesandtestwith the Configuration Cache. Currently,BaselineModuleJvmArgshas these CC issues:After this PR
Instead of capturing Gradle domain objects (SourceSets and Projects) in tasks, use providers as inputs.
==COMMIT_MSG==
Make BaselineModuleJvmArgs Configuration-Cache friendly
==COMMIT_MSG==
Possible downsides?