Skip to content

[Error-prone] Add InlineMeInliner to default patch checks#3279

Merged
bulldozer-bot[bot] merged 1 commit intodevelopfrom
ald/automatically-apply-inline-me-inliner
Sep 29, 2025
Merged

[Error-prone] Add InlineMeInliner to default patch checks#3279
bulldozer-bot[bot] merged 1 commit intodevelopfrom
ald/automatically-apply-inline-me-inliner

Conversation

@aldexis
Copy link
Contributor

@aldexis aldexis commented Sep 29, 2025

Before this PR

When libraries specify @InlineMe annotations like in https://github.com/palantir/deadlines-java/pull/188/files#diff-f8f90c9951b97fc3abe992cb927e3601222e7e3ce25efb471821039feab57432R179-R181, the current behavior would just suppress it (example), when we could instead apply the proposed fix, which is more desirable.

After this PR

==COMMIT_MSG==
[Error-prone] Add InlineMeInliner to default patch checks
==COMMIT_MSG==

Possible downsides?

This means that external libraries could in theory change your code through the use of InlineMe annotations, but given they could also just change their own code, this doesn't change too much.

@aldexis aldexis requested a review from CRogers September 29, 2025 12:24
@changelog-app
Copy link

changelog-app bot commented Sep 29, 2025

Generate changelog in changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

[Error-prone] Add InlineMeInliner to default patch checks

Check the box to generate changelog(s)

  • Generate changelog entry

@changelog-app
Copy link

changelog-app bot commented Sep 29, 2025

Successfully generated changelog entry!

What happened?

Your changelog entries have been stored in the database as part of our migration to ChangelogV3.

Need to regenerate?

Simply interact with the changelog bot comment again to regenerate these entries.

@CRogers
Copy link
Contributor

CRogers commented Sep 29, 2025

The only other issue could be external usages of @InlineMe not compiling when inlining, without us easily being a being able to fix. We have the same problem with Google's built in errorprones though, and can always revert this if it causes issues.

@CRogers
Copy link
Contributor

CRogers commented Sep 29, 2025

👍

@bulldozer-bot bulldozer-bot bot merged commit dba0426 into develop Sep 29, 2025
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the ald/automatically-apply-inline-me-inliner branch September 29, 2025 15:18
@autorelease3
Copy link

autorelease3 bot commented Sep 29, 2025

Released 6.60.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants