[Error-prone] Add InlineMeInliner to default patch checks#3279
Merged
bulldozer-bot[bot] merged 1 commit intodevelopfrom Sep 29, 2025
Merged
[Error-prone] Add InlineMeInliner to default patch checks#3279bulldozer-bot[bot] merged 1 commit intodevelopfrom
bulldozer-bot[bot] merged 1 commit intodevelopfrom
Conversation
Generate changelog in
|
✅ Successfully generated changelog entry!What happened?Your changelog entries have been stored in the database as part of our migration to ChangelogV3. Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. |
Contributor
|
The only other issue could be external usages of |
Contributor
|
👍 |
|
Released 6.60.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
When libraries specify
@InlineMeannotations like in https://github.com/palantir/deadlines-java/pull/188/files#diff-f8f90c9951b97fc3abe992cb927e3601222e7e3ce25efb471821039feab57432R179-R181, the current behavior would just suppress it (example), when we could instead apply the proposed fix, which is more desirable.After this PR
==COMMIT_MSG==
[Error-prone] Add InlineMeInliner to default patch checks
==COMMIT_MSG==
Possible downsides?
This means that external libraries could in theory change your code through the use of
InlineMeannotations, but given they could also just change their own code, this doesn't change too much.